[libcxx-commits] [PATCH] D148542: [libc++] cuchar redeclares ::mbstate_t when it's in its own clang module

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 25 12:11:19 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/include/uchar.h:49
+// When the platform doesn't provide <uchar.h>, try to get the declaration
+// for mbstate_t.
+# if __has_include(<bits/types/mbstate_t.h>)
----------------
Shouldn't we include `__mbstate_t.h` instead? Then we can tweak what that header does as needed to avoid including `wchar.h` from it unconditionally, perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148542/new/

https://reviews.llvm.org/D148542



More information about the libcxx-commits mailing list