[libcxx-commits] [PATCH] D148826: [libc++][format] Removes vector dependency.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__format/buffer.h:617-621
+#  if _LIBCPP_STD_VER >= 23
+    allocation_result __result = std::allocate_at_least(__alloc_, __capacity);
+#  else
+    __allocation_result __result = std::__allocate_at_least(__alloc_, __capacity);
+#  endif
----------------
ldionne wrote:
> Same comment, personally I think `auto __result = std::__allocate_at_least(__alloc_, __capacity);` would be better, since this is not ABI-sensitive.
> 
> If we don't feel comfortable using this trick, then we should change how we designed `__allocate_at_least`.
P2652R2 changed the interface anyways, so we might as well update it then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148826/new/

https://reviews.llvm.org/D148826