[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

As discussed, let's split the `cppm` files into a separate review so we can get the bulk of the mechanical changes in.



================
Comment at: libcxx/modules/std/format.cppm:10
+//===----------------------------------------------------------------------===//
+
+// TODO This file is two-fold
----------------
As discussed, I think this makes it too hard to distinguish what is a comment and what is an actual declaration. Thanks so much for doing the experiment -- I think it was a good idea on paper but it turns out to be a bit too hard to read.


================
Comment at: libcxx/modules/std/memory.cppm:31
+  // [allocator.tag], allocator argument tag
+  //  using std::allocator_arg; TODO INTERNAL LINKAGE
+  //  using std::allocator_arg_t TODO INTERNAL LINKAGE;
----------------
This has been fixed now. Also some stuff in `<mutex>` and `<utility>`, see D145589.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994