[libcxx-commits] [PATCH] D148928: [libc++][chrono] Adds formatter file_time.

Mon Apr 24 23:29:48 PDT 2023

Mordante added a comment.

In D148928#4290086 <https://reviews.llvm.org/D148928#4290086>, @h-vetinari wrote:

> In D148928#4289619 <https://reviews.llvm.org/D148928#4289619>, @Mordante wrote:
>
>> No not really. Some information is here https://libcxx.llvm.org/Status/Format.html (dependency "A <chrono> implementation"). I know there are no parse functions too. However I haven't spend time investigating the exact status. I still intend to work on chrono in the future, at which time I probably will create a status page. But for now I'm focusing on format and modules.
>
> Not everything has to fall on you!

True and I don't like it does. That something is on my todo list does not mean I will do it. Some items have been already been done before I had time to do them.

> But the combination of showing it "in progress" and not having a dedicated issue drastically lowers the visibility and thus the chance that someone would pick this up otherwise. Perhaps we should just open an issue?

I don't feel GitHub issues helps us here. What would help is a status page that properly documents the status. But that is also quite some work since we don't know what exactly is done.

> I'm mainly curious about getting format out of experimental status, which at the time was blocked on chrono (well not exactly blocked, but you said you preferred to wait for chrono).

I'm not sure at what time that exactly was. But I expect that was at a time I hadn't looked deeply at what chrono offers and what formatting challenges there are. At the moment I have a better understanding of chrono. I hope/expect that the experimental flag will be removed in LLVM 17. Note the feature-test macro does require the missing chrono parts to be available, so that will remain unset.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148928/new/

https://reviews.llvm.org/D148928