[libcxx-commits] [PATCH] D148499: [RISC-V libunwind]:Fix RISC-V backtrace issue

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

Please adjust `libunwind/test/signal_unwind.pass.cpp` and ensure it passes.



================
Comment at: libunwind/src/UnwindCursor.hpp:2843
+  // A signal frame will have a return address pointing to
+  // __default_sa_restorer. This code is hardwired as:
+  //
----------------
Where is __default_sa_restorer defined? Isn't it only used by Linux arm?


================
Comment at: libunwind/src/UnwindCursor.hpp:2866
+  // the trampoline. We store the mcontext inside ucontext as sigctx.
+  pint_t sigctx = sp + sizeof(siginfo_t) + kOffsetSpToSigcontext;
+
----------------
This causes
`error: use of undeclared identifier 'siginfo_t'`
on glibc riscv64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148499/new/

https://reviews.llvm.org/D148499