[libcxx-commits] [PATCH] D148566: [libcxxabi] copy back std::string_view patches from LLVM

[Nick Desaulniers via Phabricator via libcxx-commits]

nickdesaulniers added inline comments.


================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:1851
       OB += "-";
-      OB += Offset.dropFront();
+      OB += Offset.substr(1);
     } else {
----------------
nickdesaulniers wrote:
> also, std::string_view::substr may throw `std::out_of_range` which can't/shouldn't be used in libcxxabi (results in incredibly spooky linkage failures that took me longer than I'd like to admit to track down).  That should be fixed first downstream, then this change rebased on that (with those changes recopied).
https://reviews.llvm.org/D148959


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148566/new/

https://reviews.llvm.org/D148566