[libcxx-commits] [PATCH] D145589: [libc++] Make std::allocator_arg and friends conforming in C++17

[Louis Dionne via Phabricator via libcxx-commits]

ldionne updated this revision to Diff 515839.
ldionne added a comment.

Revert to previous behavior: don't use inline before C++17.

It turns out this is flagged as a C++17 extension by Clang and breaks our test suite. We need to finish the discussion on using extensions in our code before we do that, and if we decide to do it (I think we should), then we'll need additional CI to make sure e.g. GCC is happy in standard modes like C++17.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145589/new/

https://reviews.llvm.org/D145589

Files:
  libcxx/include/__functional/bind.h
  libcxx/include/__memory/allocator_arg_t.h
  libcxx/include/__mutex/tag_types.h
  libcxx/include/__utility/piecewise_construct.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145589.515839.patch
Type: text/x-patch
Size: 3875 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230421/1edd0b04/attachment.bin>