[libcxx-commits] [PATCH] D145589: [libc++] Make std::allocator_arg and friends conforming in C++17

Thu Apr 20 11:15:05 PDT 2023

philnik added a comment.

In D145589#4281652 <https://reviews.llvm.org/D145589#4281652>, @ldionne wrote:

> In D145589#4178836 <https://reviews.llvm.org/D145589#4178836>, @philnik wrote:
>
>> In D145589#4178824 <https://reviews.llvm.org/D145589#4178824>, @Mordante wrote:
>>
>>> LGTM, but I really would like to use a helper macro over `#ifdef`s.
>>
>> Another option would be to just always mark them `inline`. Both clang and GCC support this as an extension.
>
> C++11 and C++14 didn't mark those as `inline`, so I'm not sure we should (even though I agree having them non-inline makes little sense).

I don't think this will be an issue in reality. I don't think any program observes the pointer of these values in a meaningful way, so this will at most be a QoI issue in C++11 and C++14, more likely just fewer `#ifdef`s in our code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145589/new/

https://reviews.llvm.org/D145589