[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Aaron Siddhartha Mondal via Phabricator via libcxx-commits]

aaronmondal added a comment.

> Yeah we can't use new since it's a keyword.

Actually, what about renaming the `new.cppm` to `__new.cppm`? The issue with `new.cppm` is that you can't grep/ls all files in the `libcxx/modules` directory and extract the partition names from the filenames that way. Since the partition is named `std:__new`, naming the file same seems more natural.

The downside of this is that `__new` doesn't 1:1 correspond to the `<new>` header name. Since there is no `include/__new` in the same way that there is e.g. `include/__algorithm` there is little room for confusion though, and users can't directly import the partitions anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994