[libcxx-commits] [PATCH] D146397: [libc++] Make bsd_locale_fallbacks.h modular and move it into __locale/locale_base_api/

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__locale_dir/locale_base_api/bsd_locale_defaults.h:14
 
-#ifndef _LIBCPP___BSD_LOCALE_DEFAULTS_H
-#define _LIBCPP___BSD_LOCALE_DEFAULTS_H
+#ifndef _LIBCPP___SUPPORT_XLOCALE_BSD_LOCALE_DEFAULTS_H
+#define _LIBCPP___SUPPORT_XLOCALE_BSD_LOCALE_DEFAULTS_H
----------------
This doesn't seem right anymore. Please check the other ones as well.


================
Comment at: libcxx/utils/generate_iwyu_mapping.py:33
     result = []
-    temporary_mappings = {'__tuple_dir': 'tuple'}
+    temporary_mappings = {'__tuple_dir': 'tuple', '__locale_dir' : 'locale'}
     for i in detail_directories:
----------------
I thought `__tuple_dir `had been renamed to `__tuple` already, maybe you need to rebase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146397/new/

https://reviews.llvm.org/D146397