[libcxx-commits] [PATCH] D145589: [libc++] Make std::allocator_arg and friends conforming in C++17

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__functional/bind.h:67
+#elif _LIBCPP_STD_VER >= 17
+inline constexpr __ph<1>   _1{};
+inline constexpr __ph<2>   _2{};
----------------
Mordante wrote:
> I thought you had a marco `_LIBCPP_INLINE_CONSTEXPR_VAR` in a different patch, that could be sued here too.
The reason why I didn't go for that is that the specification changed from non-inline variables to inline variables.

Using something like `_LIBCPP_INLINE_CONSTEXPR_VAR` makes it look as-if we're trying to get `inline` whenever we can, which is not really the intent. LMK if that alleviates your concerns, otherwise I can introduce a macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145589/new/

https://reviews.llvm.org/D145589