[libcxx-commits] [PATCH] D148566: [libcxxabi] copy back std::string_view patches from LLVM

[Nick Desaulniers via Phabricator via libcxx-commits]

nickdesaulniers added inline comments.


================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:20
 #include "DemangleConfig.h"
-#include "StringView.h"
+#include "StringViewExtras.h"
 #include "Utility.h"
----------------
nickdesaulniers wrote:
> From the build bots:
> ```
> /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-sh1r-1/llvm-project/libcxx-ci/libcxxabi/src/demangle/ItaniumDemangle.h:20:10: fatal error: 'StringViewExtras.h' file not found
> #include "StringViewExtras.h"
>          ^~~~~~~~~~~~~~~~~~~~
> ```
> I need to copy back this file, too.
I //did// that in the parent commit https://reviews.llvm.org/D148556. Perhaps the build bot didn't test both patches together in series?

FWICT, I marked the parent revision at 1:43pm, and harbormaster marked the build tests complete at 2:16pm, but I can't tell when harbormaster //started// the test.  Perhaps I just need a rebase in order to rekick harbormaster now that the relationships between patches in the series is properly expressed in phab?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148566/new/

https://reviews.llvm.org/D148566