[libcxx-commits] [PATCH] D148632: [libc++] Add helper script libcxx-lit for running tests

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added inline comments.


================
Comment at: libcxx/utils/libcxx-lit:36
+
+build_dir="$(realpath "${1}")"
+shift
----------------
jloser wrote:
> ldionne wrote:
> > Does `realpath` work on Linux?
> It should be just fine per https://man7.org/linux/man-pages/man3/realpath.3.html
I believe realpath should be available on most systems but may not always be installed by default. Also I seem to recall it not being there on macos? But is this actually needed? Shouldn't both cmake and lit be fine with a relative path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148632/new/

https://reviews.llvm.org/D148632