[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added inline comments.


================
Comment at: libcxx/docs/Modules.rst:83-98
+  * Clang
+
+    * ``__synth_three_way_result`` does not work. There is a work-around in libc++.
+
+      * `bug report <https://github.com/llvm/llvm-project/issues/57222>`__
+      * `clang patch <https://reviews.llvm.org/D140002>`__
+      * `libc++ patch </usr/share/c++/modules/v<x>/`__
----------------
Will these problems be blockers actually? Specially for the "header-module" order problem, we can't fix it fundamentally. And I feel 'std module' is still workable in some degree with these defects. If these problems are not blockers actually, could we move the "limitations" section?


================
Comment at: libcxx/modules/CMakeLists.txt.in:48
+
+add_library(std)
+target_sources(std
----------------
Mordante wrote:
> ChuanqiXu wrote:
> > I guess we need a better library name before landing this.
> What would you propose?
> I'm not even sure we really need to, but this is something to determine during a review.
> What would you propose?

I use `libstdmodule.a` in the downstream. But it looks not good enough for the upstream.

> I'm not even sure we really need to, but this is something to determine during a review.

Ideally this should be handled by cmake (or other build systems). But we need it now to make progress. How about something like 'libc++_std_module.a'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994