[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

LGTM modulo the documentation issue. Please make sure the CI is green before landing. Note the sanitizers CI is currently broken and the AIX may also be offline. So feel free to ignore errors from these runners.



================
Comment at: libcxx/docs/DesignDocs/ABIVersioning.rst:25
 directly.
+
+-----------------
----------------



================
Comment at: libcxx/docs/index.rst:123
 Linux           i386, x86_64, arm, arm64  Only glibc-2.24 and later and no other libc is officially supported
-Windows         i386, x86_64              Both MSVC and MinGW style environments
+Windows         i386, x86_64              Both MSVC and MinGW style environments, ABI in MSVC environments is :doc:`unstable <ABIVersioning>`
 AIX 7.2TL5+     powerpc, powerpc64
----------------



================
Comment at: libcxx/docs/index.rst:123
 Linux           i386, x86_64, arm, arm64  Only glibc-2.24 and later and no other libc is officially supported
-Windows         i386, x86_64              Both MSVC and MinGW style environments
+Windows         i386, x86_64              Both MSVC and MinGW style environments, ABI in MSVC environments is unstable
 AIX 7.2TL5+     powerpc, powerpc64
----------------
davidben wrote:
> Mordante wrote:
> > How about making unstable a link to the ABI document explaining why this ABI is unstable?
> Done. Hopefully I got the syntax right?
> Done. Hopefully I got the syntax right?

CI says no. I have two suggestions that I've tested locally this fixes the link.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190