[libcxx-commits] [PATCH] D148542: [libc++] cuchar redeclares ::mbstate_t

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 18 10:58:04 PDT 2023


Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM modulo one comment. I leave the final approval to @philnik.



================
Comment at: libcxx/include/cuchar:53
+#if !defined(_LIBCPP_CXX03_LANG)
+#  include <__mbstate_t.h>  // provides ::mbstate_t
+#endif
----------------
Can you update this comment why this is needed, this is useful for future readers of the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148542/new/

https://reviews.llvm.org/D148542



More information about the libcxx-commits mailing list