[libcxx-commits] [PATCH] D148641: [libc++] Add C++20 stringstream::view()

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

Please make sure you did everything listed at https://libcxx.llvm.org/Contributing.html#pre-commit-check-list. Feel free to ask here or on Discord (in the #libcxx channel) if you have any questions.



================
Comment at: libcxx/include/sstream:878
     }
+    _LIBCPP_INLINE_VISIBILITY
+    basic_string_view<char_type, traits_type> view() const noexcept {
----------------
This should be `_LIBCPP_HIDE_FROM_ABI` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148641/new/

https://reviews.llvm.org/D148641