[libcxx-commits] [PATCH] D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 17 13:57:09 PDT 2023


mstorsjo updated this revision to Diff 514393.
mstorsjo added a comment.

Split out the main condition to a constexpr bool variable, as suggested by @Mordante, singificantly reducing the amount of ifdefs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146398/new/

https://reviews.llvm.org/D146398

Files:
  libcxx/src/std_stream.h
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/check-stderr.sh
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/check-stdout.sh
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/send-stdin.sh
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/test.dat
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcerr-wide-mode.sh.cpp
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcin-wide-mode.sh.cpp
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcout-wide-mode.sh.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146398.514393.patch
Type: text/x-patch
Size: 9948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230417/ce7195a9/attachment.bin>


More information about the libcxx-commits mailing list