[libcxx-commits] [PATCH] D144739: [libc++][chrono] Add sys_time formatter.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D144739#4274437 <https://reviews.llvm.org/D144739#4274437>, @philnik wrote:

> In D144739#4274408 <https://reviews.llvm.org/D144739#4274408>, @Mordante wrote:
>
>> According to https://sourceware.org/glibc/wiki/Glibc%20Timeline GLIBC 2.17 is over 10 years old. We don't have a fixed policy on which versions of GLIBC we support. Since most users don't run our tests and you have solved it locally I prefer to keep the code as is. If there are more bug reports with newer GLIBC versions I can look at another `#ifdef`.
>>
>> I'm actually surprised there are not more parts of the C library, we depend on, missing with such an old GLIBC version.
>
> We've actually started to only claim support for 2.24 and newer.

Thanks it seems I missed that change. (I know we had a review about it, but missed we landed it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144739/new/

https://reviews.llvm.org/D144739