[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 17 09:23:50 PDT 2023
Mordante added a comment.
A few documentation comments.
================
Comment at: libcxx/docs/DesignDocs/ABIVersioning.rst:26
+
+The exception to this is MSVC environments. Libc++ does not currently have users
+that require a stable ABI in MSVC environments, so MSVC-only changes may be
----------------
Can you make this a section `MSVC Envirionments` to make it slightly more explicit this is MSVC only.
================
Comment at: libcxx/docs/index.rst:123
Linux i386, x86_64, arm, arm64 Only glibc-2.24 and later and no other libc is officially supported
-Windows i386, x86_64 Both MSVC and MinGW style environments
+Windows i386, x86_64 Both MSVC and MinGW style environments, ABI in MSVC environments is unstable
AIX 7.2TL5+ powerpc, powerpc64
----------------
How about making unstable a link to the ABI document explaining why this ABI is unstable?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146190/new/
https://reviews.llvm.org/D146190
More information about the libcxx-commits
mailing list