[libcxx-commits] [PATCH] D142332: [libc++] Add hide_from_abi check for classes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/tools/clang_tidy_checks/hide_from_abi.cpp:98
+      call != nullptr) {
+    diag(call->getLocation(), "_LIBCPP_HIDE_FROM_ABI or _LIBCPP_HIDE_FROM_ABI_VIRTUAL is missing");
+  }
----------------
philnik wrote:
> Mordante wrote:
> > How about testing whether the method is virtual and show the proper message. This can probabl be done with a '%select' in the diagnotic message.
> I plan to merge `abi_tag_on_virtual` into `hide_from_abi`. I'd rather improve the error messages there, since I probably have to modify this part anyways.
That's fine by me too. I just like to have a better error message since it's trivial to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142332/new/

https://reviews.llvm.org/D142332