[libcxx-commits] [PATCH] D148357: [NFC][libc++] Removes sliceExpr friend.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D148357#4271209 <https://reviews.llvm.org/D148357#4271209>, @EricWF wrote:

> If we think there's no need for the friend declaration, then lets explain why we think it's unneeded in the commit message for archeology.
>
> Because I suspect the addition of the friend declaration for `__slice_expr` without needing it points to a bit of unimplemented code.

As discussed on Discord I'll revert and reland with a better commit message.

> But I don't think anybody want's to work on improving `<valarray>`?

When I read about `valarray` the first time it sounded very interesting. Maybe when C++ has SIMD support it might be interesting to see whether that can be used for valarray. (I have hopes SIMD will be available in C++26.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148357/new/

https://reviews.llvm.org/D148357