[libcxx-commits] [PATCH] D147638: [libcxxabi] [test] Fix the mingw test config

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxxabi/test/configs/llvm-libc++abi-mingw.cfg.in:6
 
+# Define _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS; when tests include
+# libcxxabi sources (some tests do #include "../src/<file>") we can't
----------------
Could we instead define it just in the tests that include libcxxabi source files? I don't think there is a lot of those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147638/new/

https://reviews.llvm.org/D147638