[libcxx-commits] [PATCH] D144499: [libc++][format] Improves width estimate.

[Corentin Jabot via Phabricator via libcxx-commits]

cor3ntin added inline comments.


================
Comment at: libcxx/utils/generate_width_estimation_table.py:197-242
+// UNICODE, INC. LICENSE AGREEMENT - DATA FILES AND SOFTWARE
+//
+// See Terms of Use <https://www.unicode.org/copyright.html>
+// for definitions of Unicode Inc.'s Data Files and Software.
+//
+// NOTICE TO USER: Carefully read the following legal agreement.
+// BY DOWNLOADING, INSTALLING, COPYING OR OTHERWISE USING UNICODE INC.'S
----------------
Mordante wrote:
> tahonermann wrote:
> > Is there something we can do to ensure this gets updated with newer Unicode releases? Perhaps pull the copyright notice from somewhere to run a comparison when the table is regenerated?
> Not at the moment. I have a reminder in my calendar.
> 
> But maybe I can make a periodic GitHub action that downloads the EastAsianWidth.txt file and compares whether it's different.
> This file start with
> ```
> # EastAsianWidth-15.0.0.txt
> # Date: 2022-05-24, 17:40:20 GMT [KW, LI]
> ```
> which I assume will change with every Unicode release.
> 
> I don't want this in the CI and possibly fail the CI since updating the Unicode files might be non-trivial. I don't expect that for this case, but the grapheme clustering might change the rules and thus need changes in the code. (And I'm not sure how Zach's papers will affect what other parts of the Unicode database we need and how stable these rules are.)
> 
> @ldionne do you have an opinion? According to the Standard we should be using the latest Unicode Standard.
> (This is part of P2736R2 and was voted in during the last plenary.)
Given the rate of change (on average once a year) I'm not sure it's worth trying to automate that license file change).
Maybe a "Here is everything that needs to be done to update unicode" document somewhere would be as good / better. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144499/new/

https://reviews.llvm.org/D144499