[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/module_std.sh.cpp:227
+#endif
+// RUN: %{clang-tidy} %{module}/std/atomic.cppm --checks='-*,libcpp-header-exportable-declarations' -config='{CheckOptions: [ {key: libcpp-header-exportable-declarations.Header, value: atomic.cppm} ]}' --load=%{test-tools}/clang_tidy_checks/libcxx-tidy.plugin -- %{compile_flags} | sort > %t.atomic.module
+// RUN: cat  %t.atomic.module >> %t.parts
----------------
ChuanqiXu wrote:
> I can't search libcpp-header-exportable-declarations. Is there a patch that haven't been uploaded?
It's in the file `libcxx/test/tools/clang_tidy_checks/header_exportable_declarations.cpp` which is part of this patch.
(It still has some issues, but I wanted to post some progress again.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994