[libcxx-commits] [PATCH] D148056: libcxx: Bring back unsigned return from wcstoull_l

[Christoph Schlosser via Phabricator via libcxx-commits]

cschlosser added a comment.

In D148056#4261085 <https://reviews.llvm.org/D148056#4261085>, @philnik wrote:

> In D148056#4260105 <https://reviews.llvm.org/D148056#4260105>, @cschlosser wrote:
>
>> In D148056#4259520 <https://reviews.llvm.org/D148056#4259520>, @philnik wrote:
>>
>>> In D148056#4259466 <https://reviews.llvm.org/D148056#4259466>, @cschlosser wrote:
>>>
>>>> Should I add a test for this as this is the second time (D141208 <https://reviews.llvm.org/D141208>) this has happened recently
>>>
>>> We don't have a musl configuration in the CI, otherwise this would have been caught.
>>
>> I see, thanks.
>>
>> The sanitizer builds are failing, I don't see how this is related though, especially as you mentioned that there isn't even a configuration for this part of the code.
>
> They are unrelated. I guess you don't have commit access?

No I don't, this is my first contribution.

Could you commit this for me please?

Also does it make sense to backport to 16?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148056/new/

https://reviews.llvm.org/D148056