[libcxx-commits] [PATCH] D147741: [libc++] unwrap iterator parameters to __uninitialized_allocator_copy before calling std::copy

Aditya Kumar via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 12 06:53:06 PDT 2023


hiraditya added a comment.

> You can look at `__algorithm/equal.h` to see how we unwrap iterators elsewhere.

I saw the changes in: https://reviews.llvm.org/D139554 and tried to adapt from there. For some reason the `_uninitialized_allocator_copy_impl(_Alloc& __alloc, _Iter1 __first1, _Sent1 __last1, _Iter2 __first2)` version still gets called unless I add the enable_if_t (see comments). But that is too restrictive and fails many of the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147741/new/

https://reviews.llvm.org/D147741



More information about the libcxx-commits mailing list