[libcxx-commits] [PATCH] D142335: [libc++][ranges] Partially implement `ranges::to`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added inline comments.


================
Comment at: libcxx/include/__ranges/to.h:71
+template <class>
+concept __always_false = false;
+
----------------
@ldionne Do you think it's worthwhile to move this concept to a dedicated header?


================
Comment at: libcxx/include/string:1932-1933
+    void __init_with_size(_InputIterator __first, _Sentinel __last, size_type __sz) {
+      if (__libcpp_is_constant_evaluated())
+        __r_.first() = __rep();
+
----------------
ldionne wrote:
> Maybe call `__default_init()` here unconditionally for consistency with above?
Doing so breaks string tests.


================
Comment at: libcxx/test/std/ranges/range.utility/range.utility.conv/to_std_containers.pass.cpp:221
+    /*
+    types::for_each(container_adaptors<int>{}, []<class From>() {
+      types::for_each(container_adaptors<double>{}, []<class To>() {
----------------
ldionne wrote:
> Looks like a leftover!
Sorry about that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142335/new/

https://reviews.llvm.org/D142335