[libcxx-commits] [PATCH] D147860: [libcxxabi] [test] Mark code following an assert(false) as unreachable

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D147860#4258788 <https://reviews.llvm.org/D147860#4258788>, @EricWF wrote:

> LGTM after addressing @phosek comment about the other delete functions.
>
> Also please leave a comment explaining why `assert` isn't catching this.

Sure, I can do that. As we’ve concluded that this test doesn’t make much sense, I think there’s little point in adding a similar marker in the other functions, as the only point of it is to silence the issue of missing a return. I’ll wait for @phosek to complete the discussion anyway, and I can still be persuaded to change it if he still wants it that way.

In D147860#4258793 <https://reviews.llvm.org/D147860#4258793>, @EricWF wrote:

> Oh, and of course, after the CI is passing. Please re-upload a new patch so that it merges.

Sure, I can do that - although the only issues in CI seem to be the same sanitizers test configs that are (or were?) failing in all jobs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147860/new/

https://reviews.llvm.org/D147860