[libcxx-commits] [libcxxabi] 7f00b2a - [libcxxabi] [test] Mark thread_local_destruction_order.pass.cpp unsupported for mingw targets

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 10 14:03:46 PDT 2023


Author: Martin Storsjö
Date: 2023-04-11T00:01:38+03:00
New Revision: 7f00b2aa75f0f090c37bf9d5ccb55fca15c35538

URL: https://github.com/llvm/llvm-project/commit/7f00b2aa75f0f090c37bf9d5ccb55fca15c35538
DIFF: https://github.com/llvm/llvm-project/commit/7f00b2aa75f0f090c37bf9d5ccb55fca15c35538.diff

LOG: [libcxxabi] [test] Mark thread_local_destruction_order.pass.cpp unsupported for mingw targets

With current versions of mingw-w64, TLS destructors that are registered
while executing TLS destructors are lost and leaked.

The root cause does get fixed further upstream in mingw-w64 in
https://github.com/mingw-w64/mingw-w64/commit/71eddccd746c56d9cde28bb5620d027d49259de9
though, but mark the test as unsupported for now. The marking can be
removed later when the version used in the CI runner has been updated
to include the fix.

Differential Revision: https://reviews.llvm.org/D147859

Added: 
    

Modified: 
    libcxxabi/test/thread_local_destruction_order.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/thread_local_destruction_order.pass.cpp b/libcxxabi/test/thread_local_destruction_order.pass.cpp
index 9daf966c209cb..c7e7717d6f04f 100644
--- a/libcxxabi/test/thread_local_destruction_order.pass.cpp
+++ b/libcxxabi/test/thread_local_destruction_order.pass.cpp
@@ -11,6 +11,13 @@
 
 // XFAIL: LIBCXX-FREEBSD-FIXME
 
+// TODO: This test does start working with newer updates of the mingw-w64
+// toolchain, when it includes the following commit:
+// https://github.com/mingw-w64/mingw-w64/commit/71eddccd746c56d9cde28bb5620d027d49259de9
+// Thus, remove this UNSUPPORTED marking after the next update of the CI
+// toolchain.
+// UNSUPPORTED: target={{.*-windows-gnu}}
+
 #include <cassert>
 #include <thread>
 


        


More information about the libcxx-commits mailing list