[libcxx-commits] [PATCH] D147850: [libc++] Implements isblank.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added a comment.

In D147850#4253141 <https://reviews.llvm.org/D147850#4253141>, @philnik wrote:

> Crazy that nobody complained about this in the past 10 years. LGTM.

Agreed, I even searched for a bug report, but there is none. Maybe it's a hint how popular locale support in C++ is ;-)

Thanks for the review!



================
Comment at: libcxx/test/std/localization/locales/locale.convenience/classification/isblank.pass.cpp:20
+  std::locale l;
+  assert(std::isblank(' ', l));
+  assert(!std::isblank('<', l));
----------------
philnik wrote:
> Is `\t` also considered blank?
It should be, but the list is not exhaustive, I did the same as for similar tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147850/new/

https://reviews.llvm.org/D147850