[libcxx-commits] [PATCH] D147859: [libcxxabi] [test] Mark thread_local_destruction_order.pass.cpp unsupported for mingw targets

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: phosek, alvinhochun.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++abi.
Herald added a reviewer: libc++abi.

With current versions of mingw-w64, TLS destructors that are registered
while executing TLS destructors are lost and leaked.

      

The root cause does get fixed further upstream in mingw-w64 in
https://github.com/mingw-w64/mingw-w64/commit/71eddccd746c56d9cde28bb5620d027d49259de9
though, but mark the test as unsupported for now, but it can be
considered supported again when the version used in the CI runner
has been updated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147859

Files:
  libcxxabi/test/thread_local_destruction_order.pass.cpp


Index: libcxxabi/test/thread_local_destruction_order.pass.cpp
===================================================================
--- libcxxabi/test/thread_local_destruction_order.pass.cpp
+++ libcxxabi/test/thread_local_destruction_order.pass.cpp
@@ -11,6 +11,13 @@
 
 // XFAIL: LIBCXX-FREEBSD-FIXME
 
+// TODO: This test does start working with newer updates of the mingw-w64
+// toolchain, when it includes the following commit:
+// https://github.com/mingw-w64/mingw-w64/commit/71eddccd746c56d9cde28bb5620d027d49259de9
+// Thus, remove this UNSUPPORTED marking after the next update of the CI
+// toolchain.
+// UNSUPPORTED: target={{.*-windows-gnu}}
+
 #include <cassert>
 #include <thread>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147859.511924.patch
Type: text/x-patch
Size: 698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230408/ea7368b7/attachment-0001.bin>