[libcxx-commits] [PATCH] D147175: [clang] Add __is_trivially_equality_comparable

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I mainly glossed over the patch and didn't do a real review.



================
Comment at: clang/lib/AST/ASTContext.cpp:2672
+                                                const RecordDecl *RD,
+                                                bool CheckIfTriviallyCOpyable) {
   assert(RD->isUnion() && "Must be union type");
----------------



================
Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46
 template <class _Tp, class _Up>
-struct __is_trivially_equality_comparable
+struct __libcpp_is_trivially_equality_comparable
     : integral_constant<bool,
----------------
This does not magically use the builtin right? Does the patch miss that parts that use the builtin or is that a followup? If it's a followup I would prefer move the libc++ code changes of this patch to a separate review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147175/new/

https://reviews.llvm.org/D147175