[libcxx-commits] [PATCH] D146804: [libcxx] Add OHOS support

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 8 05:32:32 PDT 2023


Mordante added a comment.

In D146804#4248520 <https://reviews.llvm.org/D146804#4248520>, @kpdev42 wrote:

> In D146804#4219175 <https://reviews.llvm.org/D146804#4219175>, @philnik wrote:
>
>> As usual: Do you plan to get official support for OpenHarmony in libc++? If that's the case, please take a look at https://libcxx.llvm.org/AddingNewCIJobs.html#addingnewcijobs.
>
> Sure, we will try it, thank you

That would indeed be great to have.

LGTM, modulo one remark.



================
Comment at: libcxx/include/__locale:46
+#elif defined(__OHOS_FAMILY__)
+// LiteOS libc uses musl's locales support.
+# include <__support/musl/xlocale.h>
----------------
At least I assume that was intended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146804/new/

https://reviews.llvm.org/D146804



More information about the libcxx-commits mailing list