[libcxx-commits] [PATCH] D146675: [libc++] Warn on including headers that are deprecated in C++17

[Mark de Wever via Phabricator via libcxx-commits]

Mordante requested changes to this revision.
Mordante added a comment.
This revision now requires changes to proceed.

In D146675#4220118 <https://reviews.llvm.org/D146675#4220118>, @ayzhao wrote:

> In D146675#4219987 <https://reviews.llvm.org/D146675#4219987>, @Mordante wrote:
>
>> I have not looked closely at the patch, can you please add the paper number in the summary and update the status page
>> `libcxx/doc/Status`? That makes reviewing the changes a lot easier.
>
> The headers were marked deprecated in p0063r3 <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0063r3.html>, which, interestingly enough, is already marked complete in the status page <https://github.com/llvm/llvm-project/blob/f23ea4cbd443601a0d6666a5fae6558243051348/libcxx/docs/Status/Cxx17Papers.csv#L46>.

Thanks for the info.



================
Comment at: libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp:50
+// Prevent <ccomplex>, <cstdbool>, and <ctgmath from generating deprecated warnings for this test.
+#define _LIBCPP_DISABLE_DEPRECATION_WARNINGS
+
----------------
philnik wrote:
> and move it near the `XFAIL` above.
This will fail when running the tests with `_LIBCPP_DISABLE_DEPRECATION_WARNINGS` already defined.

I'm not really happy with blanket disabling the deprecation warnings in tests. Basically this changes the behaviour of these tests and they are not tested in the typical libc++ configuration. I really would like to see a more fine-grained approach in the basic generation script instead of this approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146675/new/

https://reviews.llvm.org/D146675