[libcxx-commits] [PATCH] D145508: [libc++] Reject standard attributes which are extensions in libcpp-uglify-attributes

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D145508#4252137 <https://reviews.llvm.org/D145508#4252137>, @rsmith wrote:

> There still appear to be problems after this patch. It looks like a test that defines these tokens to "weird" things and then tries including the libc++ headers would have caught these issues.

That would have caught this specific case, but wouldn't catch using other attributes in their pretty variants. I rather go conservative here, i.e. allow specific attributes instead of trying to ban some. I'll try to add something to also check the preprocessor checks in another patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145508/new/

https://reviews.llvm.org/D145508