[libcxx-commits] [PATCH] D144739: [libc++][chrono] Add sys_time formatter.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__chrono/convert_to_tm.h:102
+    } else
+      static_assert(sizeof(_ChronoT) == 0, "Add the missing clock specialization");
+  } else if constexpr (chrono::__is_duration<_ChronoT>::value) {
----------------
ldionne wrote:
> It would be nice to implement this code path for the clocks that we do implement in libc++ for LLVM 17, to avoid the library being inconsistent with the clocks that it provides.
I agree that would be nice. This is on my TODO list. Note that we still miss parts of chrono for the clocks and TZDB. Also the there is no support for parse. So in general C++20 chrono is not in a great shape in libc++. (Note all chrono things are quite high on my priority list, but not at the top. I hope to get some things in LLVM 17, everything seems unlikely due to how much time I have to work on libc++.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144739/new/

https://reviews.llvm.org/D144739