[libcxx-commits] [PATCH] D147629: [libcxxabi, libunwind] [test] Quote the python path properly for LIB*_EXECUTOR

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
mstorsjo requested review of this revision.
Herald added a project: libc++abi.
Herald added a reviewer: libc++abi.

This is the same as c218c80c730a14a1cbcebd588b18220a879702c6 <https://reviews.llvm.org/rGc218c80c730a14a1cbcebd588b18220a879702c6>,
but for libcxxabi and libunwind.

This fixes running tests on Windows with Python installed in "C:\Program Files\Python".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147629

Files:
  libcxxabi/test/CMakeLists.txt
  libunwind/test/CMakeLists.txt


Index: libunwind/test/CMakeLists.txt
===================================================================
--- libunwind/test/CMakeLists.txt
+++ libunwind/test/CMakeLists.txt
@@ -10,7 +10,7 @@
 pythonize_bool(LIBUNWIND_ENABLE_CET)
 pythonize_bool(LIBUNWIND_ENABLE_THREADS)
 pythonize_bool(LIBUNWIND_USES_ARM_EHABI)
-set(LIBUNWIND_EXECUTOR "${Python3_EXECUTABLE} ${LIBUNWIND_LIBCXX_PATH}/utils/run.py" CACHE STRING
+set(LIBUNWIND_EXECUTOR "\\\"${Python3_EXECUTABLE}\\\" ${LIBUNWIND_LIBCXX_PATH}/utils/run.py" CACHE STRING
     "Executor to use when running tests.")
 
 set(AUTO_GEN_COMMENT "## Autogenerated by libunwind configuration.\n# Do not edit!")
Index: libcxxabi/test/CMakeLists.txt
===================================================================
--- libcxxabi/test/CMakeLists.txt
+++ libcxxabi/test/CMakeLists.txt
@@ -8,7 +8,7 @@
 endmacro()
 
 pythonize_bool(LIBCXXABI_USE_LLVM_UNWINDER)
-set(LIBCXXABI_EXECUTOR "${Python3_EXECUTABLE} ${LIBCXXABI_LIBCXX_PATH}/utils/run.py" CACHE STRING
+set(LIBCXXABI_EXECUTOR "\\\"${Python3_EXECUTABLE}\\\" ${LIBCXXABI_LIBCXX_PATH}/utils/run.py" CACHE STRING
     "Executor to use when running tests.")
 
 if (LIBCXXABI_ENABLE_SHARED)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147629.511130.patch
Type: text/x-patch
Size: 1181 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230405/14bf9df8/attachment.bin>