[libcxx-commits] [PATCH] D147628: [libcxxabi, libunwind] [test] Place output from tests under a 'test' subdir

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
mstorsjo requested review of this revision.
Herald added a project: libc++abi.
Herald added a reviewer: libc++abi.

Previously, all the output from the tests were placed directly in
the build directory. The tests produce a couple directories named
`__config_{exec,cache,src}__` which are easy to distinguish, and
the output from the individual tests were placed directly in a
directory named `Output`.

This is the same change as
736c6e246f5398331d83edd204a846cc967ad5c6 <https://reviews.llvm.org/rG736c6e246f5398331d83edd204a846cc967ad5c6>, but for the libcxxabi
and libunwind test suites.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147628

Files:
  libcxxabi/test/configs/cmake-bridge.cfg.in
  libunwind/test/configs/cmake-bridge.cfg.in


Index: libunwind/test/configs/cmake-bridge.cfg.in
===================================================================
--- libunwind/test/configs/cmake-bridge.cfg.in
+++ libunwind/test/configs/cmake-bridge.cfg.in
@@ -20,7 +20,7 @@
 config.test_source_root = os.path.join('@LIBUNWIND_SOURCE_DIR@', 'test')
 config.test_format = libcxx.test.format.CxxStandardLibraryTest()
 config.recursiveExpansionLimit = 10
-config.test_exec_root = '@CMAKE_BINARY_DIR@'
+config.test_exec_root = os.path.join('@CMAKE_BINARY_DIR@', 'test')
 
 # Add a few features that are common to all the configurations
 if @LIBUNWIND_USES_ARM_EHABI@:
Index: libcxxabi/test/configs/cmake-bridge.cfg.in
===================================================================
--- libcxxabi/test/configs/cmake-bridge.cfg.in
+++ libcxxabi/test/configs/cmake-bridge.cfg.in
@@ -21,7 +21,7 @@
 config.test_source_root = os.path.join('@LIBCXXABI_SOURCE_DIR@', 'test')
 config.test_format = libcxx.test.format.CxxStandardLibraryTest()
 config.recursiveExpansionLimit = 10
-config.test_exec_root = '@CMAKE_BINARY_DIR@'
+config.test_exec_root = os.path.join('@CMAKE_BINARY_DIR@', 'test')
 
 # TODO: This is a non-standard Lit attribute and we should have another way of accessing this.
 config.host_triple = '@LLVM_HOST_TRIPLE@'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147628.511129.patch
Type: text/x-patch
Size: 1281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230405/0cb8b15b/attachment-0001.bin>