[libcxx-commits] [PATCH] D147473: [libc++] Remove the synopses

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 3 16:36:28 PDT 2023


var-const added a comment.

In D147473#4241871 <https://reviews.llvm.org/D147473#4241871>, @philnik wrote:

> In D147473#4241835 <https://reviews.llvm.org/D147473#4241835>, @var-const wrote:
>
>> Has this been discussed previously, e.g. on Discord?
>
> This came up at https://reviews.llvm.org/D144994?id=502156#inline-1403408. Given that often nothing happens without a patch w.r.t. there kinds of changes I thought I'd create one, but I'm happy to discuss this further if there are any objections to this change.

Thanks. I thought there must have been some context there. Personally, I also don't find our synopses very useful. They never feel very reliable since it's so easy for them to go out of sync, they make headers less readable (you have to scroll through a wall of text to get to actual code, sometimes the code is spliced between 2 or more walls of text, e.g. in `<map>` or `<vector>`), they make grepping through headers more painful due to extra matches, they add extra boilerplate to every patch that adds new functionality, and so on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147473/new/

https://reviews.llvm.org/D147473



More information about the libcxx-commits mailing list