[libcxx-commits] [PATCH] D145628: [ASan][libcxx] A way to turn off annotations for containers with a specific allocator

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM with nits addressed.



================
Comment at: libcxx/docs/UsingLibcxx.rst:538
+  template <class T>
+  struct std::__asan_annotate_container_with_allocator<user_allocator<T>> : false_type {};
+  #endif
----------------
hans wrote:
> Should it be `std::false_type`?
yes


================
Comment at: libcxx/include/__memory/allocator_traits.h:420
+template <class _Tp>
+struct __asan_annotate_container_with_allocator< allocator<_Tp> > : true_type {};
+#endif
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145628/new/

https://reviews.llvm.org/D145628