[libcxx-commits] [PATCH] D134912: [libc++] Disable int128_t and ship filesystem on Windows by default

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added a comment.

In D134912#3826856 <https://reviews.llvm.org/D134912#3826856>, @ldionne wrote:

> In D134912#3825356 <https://reviews.llvm.org/D134912#3825356>, @mstorsjo wrote:
>
>> Generally, `s/Windows/MSVC/` for the whole commit message,
>
> Right, I'll fix that.
>
> I know @rnk had discussed shipping `int128_t` support a while back, I'd like to hear from him whether there are plans to do this in the short term (the next few weeks). Otherwise, we'll ship this and take a break if we want to use `int128_t` support in filesystem in the future (which I guess we don't have to). We have other similar situations w.r.t. ranges already FWIW (with `no_unique_address`), so there is precedent for not being fully ABI stable on Windows.

Sorry, I think this task was assigned to someone who has since left our team, and it's not likely to happen soon.

I think the way forward here is to add `/DEFAULTLIB:clang_rt.builtins-${arch}.lib` to LLVM objects when i128 is present. I think we have some prior art for this around the _fltused symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134912/new/

https://reviews.llvm.org/D134912