[libcxx-commits] [PATCH] D134969: [libunwind] Fix compile error with CROSS_UNWINDING

Florian Mayer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 30 11:51:03 PDT 2022


fmayer added a comment.

In D134969#3827883 <https://reviews.llvm.org/D134969#3827883>, @MaskRay wrote:

> Phabricator doesn't work like other review systems where you use `WANT_LGTM=all`. There is usually no need to remove a reviewer except a few cases, e.g. a reviewer is apparently not involved in llvm-project for a long time, a reviewer removes themselves from the reviewer list.
> Not for this case: sometimes removing a reviewer can be perceived negatively, e.g. whether the patch author wants to bypass someone's opinion.

This was meant as a signal that I am no longer waiting for or expecting approval from compnerd@


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134969/new/

https://reviews.llvm.org/D134969



More information about the libcxx-commits mailing list