[libcxx-commits] [PATCH] D134912: [libc++] Disable int128_t and ship filesystem on Windows by default

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 30 05:45:58 PDT 2022


ldionne added a comment.

In D134912#3825356 <https://reviews.llvm.org/D134912#3825356>, @mstorsjo wrote:

> Generally, `s/Windows/MSVC/` for the whole commit message,

Right, I'll fix that.

I know @rnk had discussed shipping `int128_t` support a while back, I'd like to hear from him whether there are plans to do this in the short term (the next few weeks). Otherwise, we'll ship this and take a break if we want to use `int128_t` support in filesystem in the future (which I guess we don't have to). We have other similar situations w.r.t. ranges already FWIW (with `no_unique_address`), so there is precedent for not being fully ABI stable on Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134912/new/

https://reviews.llvm.org/D134912



More information about the libcxx-commits mailing list