[libcxx-commits] [PATCH] D134914: [libc++] Add missing requirement for en_US locale to test

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, but I would consider an alternate approach and not add this locale to `features.py`.



================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_char.pass.cpp:16
 
+// REQUIRES: locale.en_US
+
----------------
Looking at the test it doesn't really matter which locale is used. So I would suggest to use an existing locale in this patch instead, and update the commit title and message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134914/new/

https://reviews.llvm.org/D134914