[libcxx-commits] [PATCH] D134914: [libc++] Add missing requirement for en_US locale to test

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added reviewers: mstorsjo, Mordante.
Herald added a subscriber: arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Just like we guard other tests with `REQUIRES: locale.en_US.UTF-8`, it makes sense to
guard this test for its usage of the en_US locale.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134914

Files:
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_char.pass.cpp
  libcxx/utils/libcxx/test/features.py


Index: libcxx/utils/libcxx/test/features.py
===================================================================
--- libcxx/utils/libcxx/test/features.py
+++ libcxx/utils/libcxx/test/features.py
@@ -221,6 +221,7 @@
 # names on various systems. Each locale is considered supported if any of the
 # alternative names is supported.
 locales = {
+  'en_US':           ['en_US'],
   'en_US.UTF-8':     ['en_US.UTF-8', 'en_US.utf8', 'English_United States.1252'],
   'fr_FR.UTF-8':     ['fr_FR.UTF-8', 'fr_FR.utf8', 'French_France.1252'],
   'ja_JP.UTF-8':     ['ja_JP.UTF-8', 'ja_JP.utf8', 'Japanese_Japan.923'],
Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_char.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_char.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_char.pass.cpp
@@ -13,6 +13,8 @@
 // explicit codecvt_byname(const char* nm, size_t refs = 0);
 // explicit codecvt_byname(const string& nm, size_t refs = 0);
 
+// REQUIRES: locale.en_US
+
 #include <locale>
 #include <cassert>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134914.464062.patch
Type: text/x-patch
Size: 1215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220929/5df2a7fa/attachment.bin>