[libcxx-commits] [PATCH] D134912: [libc++] Disable int128_t and ship filesystem on Windows by default

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Generally, `s/Windows/MSVC/` for the whole commit message, since there’s no issue for mingw configurations (I’ve shipped `std::filesystem` for 1,5 years there already, with the implementation using int128). Other than that, it does look reasonable to me.

One of the arguments back then was that it would be an ABI break when/if we’d enable int128 in the future. At this point, when int128 support isn’t really here yet, I kinda agree that we’ll just have to take that ABI break then (IIRC we generally consider the MSVC/clang-cl port of libc++ not entirely ABI stable anyway?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134912/new/

https://reviews.llvm.org/D134912