[libcxx-commits] [PATCH] D134830: [libc++] Simplify transitive includes test and fix a bug

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 29 12:11:43 PDT 2022


ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/transitive_includes_to_csv.py:142
         header = includes[0]
-        for include in sorted(set(includes[1:])):
+        for include in sorted(includes[1:]):
             if header == include:
----------------
Mordante wrote:
> This seems duplicated from D134829.
I actually moved it to inside `parse_file`, since IMO it made more sense to ensure that the output of `parse_file` itself had no duplicates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134830/new/

https://reviews.llvm.org/D134830



More information about the libcxx-commits mailing list