[libcxx-commits] [PATCH] D134830: [libc++] Simplify transitive includes test and fix a bug

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 29 08:54:07 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM when the CI passes.



================
Comment at: libcxx/test/libcxx/transitive_includes_to_csv.py:88
+    This effectively generates the dependency graph of C++ Standard Library headers of the header
+    whose --trace-include it is.
+    """
----------------



================
Comment at: libcxx/test/libcxx/transitive_includes_to_csv.py:142
         header = includes[0]
-        for include in sorted(set(includes[1:])):
+        for include in sorted(includes[1:]):
             if header == include:
----------------
This seems duplicated from D134829.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134830/new/

https://reviews.llvm.org/D134830



More information about the libcxx-commits mailing list