[libcxx-commits] [PATCH] D134829: [libc++] Include skipped headers in the --trace-includes output

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 29 08:46:45 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

I've downloaded the patch and had a look at the raw generated files with the `-fshow-skipped-includes` flag. With this additional information I think we can look at some other improvements. Not sure whether we want them in these files, but we can in the `.dot` file. I'll message you on Discord to discuss that. Obviously that's out of the scope of this patch.

Thanks for finding `-fshow-skipped-includes`, this makes the output better.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134829/new/

https://reviews.llvm.org/D134829



More information about the libcxx-commits mailing list